From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Kiryl Shutsemau <kas@kernel.org>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
kvm@vger.kernel.org, Reinette Chatre <reinette.chatre@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>,
chao.p.peng@intel.com, xiaoyao.li@intel.com
Subject: [PATCH 2/2] x86/split_lock: Describe #AC handling in TDX guest kernel log
Date: Wed, 26 Nov 2025 18:02:04 +0800 [thread overview]
Message-ID: <20251126100205.1729391-3-xiaoyao.li@intel.com> (raw)
In-Reply-To: <20251126100205.1729391-1-xiaoyao.li@intel.com>
X86_FEATURE_HYPERVISOR and X86_FEATURE_BUS_LOCK_DETECT are always
enumerated in a TDX guest because the corresponding CPUID values are
fixed to 1 by the TDX module. Similar to a normal guest, a TDX guest
never enumerates X86_FEATURE_SPLIT_LOCK_DETECT.
When "split_lock_detect=off", the TDX guest kernel log shows:
x86/split lock detection: disabled
and with other settings, it shows:
x86/split lock detection: #DB: ...
However, if the host enables split lock detection, a TDX guest receives
#AC regardless of its own "split_lock_detect" configuration. The actual
behavior does not match what the kernel log claims.
Call out the possible #AC behavior on TDX and highlight that this behavior
depends on the host's enabling of split lock detection.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
arch/x86/kernel/cpu/bus_lock.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/kernel/cpu/bus_lock.c b/arch/x86/kernel/cpu/bus_lock.c
index f278e4ea3dd4..18695214d214 100644
--- a/arch/x86/kernel/cpu/bus_lock.c
+++ b/arch/x86/kernel/cpu/bus_lock.c
@@ -437,6 +437,9 @@ static void sld_state_show(void)
pr_info("#DB: setting system wide bus lock rate limit to %u/sec\n", bld_ratelimit.burst);
break;
}
+
+ if (cpu_feature_enabled(X86_FEATURE_TDX_GUEST))
+ pr_info("tdx: #AC depends on host configuration: crashing the kernel on kernel split_locks and sending SIGBUS on user-space split_locks\n");
}
void __init sld_setup(struct cpuinfo_x86 *c)
--
2.43.0
prev parent reply other threads:[~2025-11-26 10:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 10:02 [PATCH 0/2] x86/split_lock: Fix and enhancement for TDX guest Xiaoyao Li
2025-11-26 10:02 ` [PATCH 1/2] x86/split_lock: Don't try to handle user split lock in " Xiaoyao Li
2025-11-26 11:25 ` Kiryl Shutsemau
2025-11-26 12:17 ` Xiaoyao Li
2025-11-26 13:35 ` Kiryl Shutsemau
2025-11-27 2:00 ` Xiaoyao Li
2025-11-27 16:16 ` Kiryl Shutsemau
2025-11-27 16:55 ` Andrew Cooper
2025-11-28 2:40 ` Xiaoyao Li
2025-11-28 2:28 ` Xiaoyao Li
2025-12-17 10:56 ` Xiaoyao Li
2025-11-26 10:02 ` Xiaoyao Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126100205.1729391-3-xiaoyao.li@intel.com \
--to=xiaoyao.li@intel.com \
--cc=bp@alien8.de \
--cc=chao.p.peng@intel.com \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox