Re: [PATCH v2 02/11] coco/guest: Move shared guest CC infrastructure to drivers/virt/coco/guest/

[Dan Williams <dan.j.williams@intel.com>]

Huang, Kai wrote:
> On Mon, 2025-03-03 at 23:14 -0800, Dan Williams wrote:
> > In preparation for creating a new drivers/virt/coco/host/ directory to
> > house shared host driver infrastructure for confidential computing, move
> > configfs-tsm to a guest/ sub-directory. The tsm.ko module is renamed to
> > tsm_reports.ko. The old tsm.ko module was only ever demand loaded by
> > kernel internal dependencies, so it should not affect existing userspace
> > module install scripts.
> > 
> > The new drivers/virt/coco/guest/ is also a preparatory landing spot for
> > new / optional TSM Report mechanics like a TCB stability enumeration /
> > watchdog mechanism. To be added later.
> > 
> > 
> 
> [...]
> 
> > diff --git a/drivers/virt/coco/Makefile b/drivers/virt/coco/Makefile
> > index c3d07cfc087e..885c9ef4e9fc 100644
> > --- a/drivers/virt/coco/Makefile
> > +++ b/drivers/virt/coco/Makefile
> > @@ -2,9 +2,9 @@
> >  #
> >  # Confidential computing related collateral
> >  #
> > -obj-$(CONFIG_TSM_REPORTS)	+= tsm.o
> >  obj-$(CONFIG_EFI_SECRET)	+= efi_secret/
> >  obj-$(CONFIG_ARM_PKVM_GUEST)	+= pkvm-guest/
> >  obj-$(CONFIG_SEV_GUEST)		+= sev-guest/
> >  obj-$(CONFIG_INTEL_TDX_GUEST)	+= tdx-guest/
> >  obj-$(CONFIG_ARM_CCA_GUEST)	+= arm-cca-guest/
> > +obj-$(CONFIG_TSM_REPORTS)	+= guest/
> > 
> 
> Would it make more sense to also move 'pkvm-guest', 'sev-guset', 'tdx-guest' and
> 'arm-cca-guest' under the new 'guest/'?

If folks want that. The main motivation is that common infrastructure
for the host side should live in a separate directory from common
infrastructure for the guest side, but for now I will live the
vendor-specific guest directories alone.