Re: [PATCH v9 07/23] x86/virt/seamldr: Add a helper to retrieve P-SEAMLDR information

[Chao Gao <chao.gao@intel.com>]

>> Note that there are two distinct P-SEAMLDR APIs with similar names:
>> 
>>   SEAMLDR.INFO: Returns a SEAMLDR_INFO structure containing SEAMLDR
>>                 information such as version and remaining updates.
>> 
>>   SEAMLDR.SEAMINFO: Returns a SEAMLDR_SEAMINFO structure containing SEAM
>>                     and system information such as Convertible Memory
>> 		    Regions (CMRs) and number of CPUs and sockets.
>> 
>> The former is used here.
>This doesn't help.
>
>"SEAMLDR.INFO" is metadata about the loader. It's metadata for the
>update process.
>
>"SEAMLDR.SEAMINFO" is metadata about the module. It is for the module
>init process, not for the update process.

Thanks for rewriting this.

One small nuance is that SEAMLDR.SEAMINFO is really about SEAM mode
rather than the loaded module itself. So I think this is a bit more
accurate:

SEAMLDR.SEAMINFO is metadata about SEAM mode. It is used for module
initialization, not for the update process.

>
>Right? Isn't that a billion times more useful and actually helps
>differentiate them?
>
>Also, more nits: I hate former/latter too. It makes me stop reading and
>have to go back *EVER* *TIME*. I hate that particular english construct.
>It's horrid.

I will avoid former/latter wording in future patches.