Linux Confidential Computing Development
 help / color / mirror / Atom feed
From: Peter Fang <peter.fang@intel.com>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: dave.hansen@linux.intel.com, rick.p.edgecombe@intel.com,
	xiaoyao.li@intel.com, linux-coco@lists.linux.dev,
	kvm@vger.kernel.org, x86@kernel.org,
	"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH v2] x86/tdx: Harden exports
Date: Fri, 18 Sep 2026 02:36:29 -0700	[thread overview]
Message-ID: <aq0GHXV67ROAhILB@intel.com> (raw)
In-Reply-To: <20260917110714.1587301-1-nik.borisov@suse.com>

On Thu, Sep 17, 2026 at 02:07:14PM +0300, Nikolay Borisov wrote:
> tdx_* function aren't supposed to be used by the kernel at large, rather
> they are mostly used by KVM and a very small number of them are exposed
> via the tdx-guest/tdx-host drivers. Reflect this fact in their

"exposed via" sounds a bit off? Perhaps "exposed to"?

And this patch only touches functions exported to tdx-guest... In fact
tdx-host only uses functions from arch/x86/virt/vmx/tdx/ (guest code vs
host code). Maybe the log could be a bit more precise.

> EXPORT_SYMBOL* declarations.
> 
> Reported-by: Michal Koutný <mkoutny@suse.com>
> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
> ---
> 
> V2:
>  * Drop the change to tdx_kvm_hypercall
> 
>  arch/x86/coco/tdx/tdx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

  reply	other threads:[~2026-09-18  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 11:07 [PATCH v2] x86/tdx: Harden exports Nikolay Borisov
2026-09-18  9:36 ` Peter Fang [this message]
2026-09-18 10:03   ` Nikolay Borisov
2026-09-18 20:25     ` Peter Fang
2026-09-25  7:42 ` Nikolay Borisov
2026-09-25 11:19 ` Kiryl Shutsemau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq0GHXV67ROAhILB@intel.com \
    --to=peter.fang@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=mkoutny@suse.com \
    --cc=nik.borisov@suse.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox