Re: [PATCH v2] x86/tdx: Harden exports

[Nikolay Borisov <nik.borisov@suse.com>]

On 18.09.26 г. 12:36 ч., Peter Fang wrote:
> On Thu, Sep 17, 2026 at 02:07:14PM +0300, Nikolay Borisov wrote:
>> tdx_* function aren't supposed to be used by the kernel at large, rather
>> they are mostly used by KVM and a very small number of them are exposed
>> via the tdx-guest/tdx-host drivers. Reflect this fact in their
> 
> "exposed via" sounds a bit off? Perhaps "exposed to"?

What I meant was that the functionality of those functions is exposed 
via the tdx-guest/tdx-host drivers. I.e those drivers present interfaces 
to userspace to enable them to use the functionality of said functions. 
I.e those functions are only used by those drivers.


> 
> And this patch only touches functions exported to tdx-guest... In fact
> tdx-host only uses functions from arch/x86/virt/vmx/tdx/ (guest code vs
> host code). Maybe the log could be a bit more precise.

Fair point.

> 
>> EXPORT_SYMBOL* declarations.
>>
>> Reported-by: Michal Koutný <mkoutny@suse.com>
>> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
>> ---
>>
>> V2:
>>   * Drop the change to tdx_kvm_hypercall
>>
>>   arch/x86/coco/tdx/tdx.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>