RE: Testing the geode-aes driver with the tcrypt module completely freezes the machine

["Martin Schiller" <mschiller@tdt.de>]

On Thursday, May 03, 2007 3:23 PM, Evgeniy Polyakov wrote:

> On Thu, May 03, 2007 at 03:12:43PM +0200, Martin Schiller
> (mschiller@tdt.de) wrote: 
>> The freeze is the result of an invinite while-loop in the function
>> geode_ecb_encrypt() (and maybe also in the geode_ecb_decrypt()).
>> 
>> The cause for this seems to be, that the op->src == op->dst whereby
>> the geode_aes_crypt() function does nothing at all, and so the value
>> of nbytes will never be changed.
> 
> Hm, driver does not perform encryption in-place at all.
> Since we did not hear from AMD quite for a while, could you please
> remove src==dst check in geode_aes_crypt() and run tests again. If it
> is software protection against hardware bug, I doubt such hardware
> should be used at all...  
> 

Removing the src==dst check solves the freeze problem, but the
encryption/decryption results are wrong:

Encryption:
Should be: 	69c4e0d86a7b0430d8cdb78070b4c55a
But is:	c8a331ff8edd3db175e1545dbefb760b

Decryption:
Should be:	00112233445566778899aabbccddeeff
But is:	69c4e0d86a7b0430d8cdb78070b4c55a (same as input)


Regards,
Martin