Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Martin Schiller <mschiller@tdt.de>
Cc: linux-crypto@vger.kernel.org
Subject: Re: Testing the geode-aes driver with the tcrypt module completely freezes the machine
Date: Thu, 3 May 2007 17:23:10 +0400	[thread overview]
Message-ID: <20070503132310.GA21082@2ka.mipt.ru> (raw)
In-Reply-To: <000601c78d84$bc24b430$1a04010a@V505CP>

On Thu, May 03, 2007 at 03:12:43PM +0200, Martin Schiller (mschiller@tdt.de) wrote:
> The freeze is the result of an invinite while-loop in the function
> geode_ecb_encrypt()
> (and maybe also in the geode_ecb_decrypt()).
> 
> The cause for this seems to be, that the op->src == op->dst whereby the
> geode_aes_crypt() function does nothing at all,
> and so the value of nbytes will never be changed.

Hm, driver does not perform encryption in-place at all.
Since we did not hear from AMD quite for a while, could you please
remove src==dst check in geode_aes_crypt() and run tests again.
If it is software protection against hardware bug, I doubt such hardware
should be used at all...

> Regards,
> Martin

-- 
	Evgeniy Polyakov

  reply	other threads:[~2007-05-03 13:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 13:12 Testing the geode-aes driver with the tcrypt module completely freezes the machine Martin Schiller
2007-05-03 13:23 ` Evgeniy Polyakov [this message]
2007-05-03 13:49   ` Herbert Xu
2007-05-03 14:47     ` Jordan Crouse
2007-05-03 16:53       ` Evgeniy Polyakov
2007-05-03 14:08   ` Martin Schiller
2007-05-03 14:47     ` Evgeniy Polyakov
  -- strict thread matches above, loose matches on Subject: below --
2007-04-26  9:04 Martin Schiller
2007-04-26 11:05 ` Sebastian Siewior
2007-04-26 11:27   ` Martin Schiller
2007-04-27  8:10 ` Herbert Xu
2007-04-27  9:50   ` Evgeniy Polyakov
2007-04-27  9:53     ` Evgeniy Polyakov
2007-05-03  6:19   ` Martin Schiller
2007-05-03  7:57     ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070503132310.GA21082@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=linux-crypto@vger.kernel.org \
    --cc=mschiller@tdt.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox