* [PATCH 1/2] crypto: sahara - Staticize local symbol
@ 2013-08-09 7:57 Jingoo Han
2013-08-14 10:49 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-09 7:57 UTC (permalink / raw)
To: Herbert Xu
Cc: David S. Miller, linux-crypto, 'Javier Martin',
Jingoo Han
This local symbol is used only in this file.
Fix the following sparse warnings:
drivers/crypto/sahara.c:420:6: warning: symbol 'sahara_watchdog' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/crypto/sahara.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index c3dc1c0..b076d81 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -417,7 +417,7 @@ static void sahara_aes_done_task(unsigned long data)
dev->req->base.complete(&dev->req->base, dev->error);
}
-void sahara_watchdog(unsigned long data)
+static void sahara_watchdog(unsigned long data)
{
struct sahara_dev *dev = (struct sahara_dev *)data;
unsigned int err = sahara_read(dev, SAHARA_REG_ERRSTATUS);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] crypto: sahara - Staticize local symbol
2013-08-09 7:57 [PATCH 1/2] crypto: sahara - Staticize local symbol Jingoo Han
@ 2013-08-14 10:49 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2013-08-14 10:49 UTC (permalink / raw)
To: Jingoo Han; +Cc: David S. Miller, linux-crypto, 'Javier Martin'
On Fri, Aug 09, 2013 at 04:57:48PM +0900, Jingoo Han wrote:
> This local symbol is used only in this file.
> Fix the following sparse warnings:
>
> drivers/crypto/sahara.c:420:6: warning: symbol 'sahara_watchdog' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Both patches applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-14 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 7:57 [PATCH 1/2] crypto: sahara - Staticize local symbol Jingoo Han
2013-08-14 10:49 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox