From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
naveen@kernel.org, dtsen@linux.ibm.com,
segher@kernel.crashing.org, stable@vger.kernel.org
Subject: Re: [PATCH] crypto: powerpc/poly1305 - add depends on BROKEN for now
Date: Mon, 19 May 2025 15:55:16 +0200 [thread overview]
Message-ID: <02c22854-eebf-4ad1-b89e-8c2b65ab8236@csgroup.eu> (raw)
In-Reply-To: <aCVNG2lm9x9dzu6x@gondor.apana.org.au>
Le 15/05/2025 à 04:10, Herbert Xu a écrit :
> On Wed, May 14, 2025 at 09:29:33AM -0700, Eric Biggers wrote:
>>
>> I didn't notice that. Probably, though I don't have time to review this subtle
>> Poly1305 code. Especially with all the weird unions in the code. Would be
>> great if the PowerPC folks would take a look.
>
> Of course more reviews would be great and I think they're all on
> the cc list.
>
> I did test this by manually forcing the conversion, which is how
> I discovered that powerpc wasn't even using donna64.
>
As far as I can see related patches found in linux-next tree were not
sent to linuxppc-dev@lists.ozlabs.org.
Could you resend them, and split out the introduction of
CONFIG_ARCH_SUPPORTS_INT128 from other parts of patch "crypto:
powerpc/poly1305 - Add SIMD fallback" and add the lib/tishift.S in the
patch which adds CONFIG_ARCH_SUPPORTS_INT128 ?
Thanks
Christophe
next prev parent reply other threads:[~2025-05-19 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 5:18 [PATCH] crypto: powerpc/poly1305 - add depends on BROKEN for now Eric Biggers
2025-05-14 9:41 ` Herbert Xu
2025-05-14 16:29 ` Eric Biggers
2025-05-15 2:10 ` Herbert Xu
2025-05-19 13:55 ` Christophe Leroy [this message]
2025-05-20 2:32 ` Herbert Xu
2025-05-20 5:17 ` Christophe Leroy
2025-05-20 2:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02c22854-eebf-4ad1-b89e-8c2b65ab8236@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=dtsen@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox