From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, naveen@kernel.org,
dtsen@linux.ibm.com, segher@kernel.crashing.org,
stable@vger.kernel.org
Subject: Re: [PATCH] crypto: powerpc/poly1305 - add depends on BROKEN for now
Date: Thu, 15 May 2025 10:10:35 +0800 [thread overview]
Message-ID: <aCVNG2lm9x9dzu6x@gondor.apana.org.au> (raw)
In-Reply-To: <20250514162933.GB1236@sol>
On Wed, May 14, 2025 at 09:29:33AM -0700, Eric Biggers wrote:
>
> I didn't notice that. Probably, though I don't have time to review this subtle
> Poly1305 code. Especially with all the weird unions in the code. Would be
> great if the PowerPC folks would take a look.
Of course more reviews would be great and I think they're all on
the cc list.
I did test this by manually forcing the conversion, which is how
I discovered that powerpc wasn't even using donna64.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-05-15 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 5:18 [PATCH] crypto: powerpc/poly1305 - add depends on BROKEN for now Eric Biggers
2025-05-14 9:41 ` Herbert Xu
2025-05-14 16:29 ` Eric Biggers
2025-05-15 2:10 ` Herbert Xu [this message]
2025-05-19 13:55 ` Christophe Leroy
2025-05-20 2:32 ` Herbert Xu
2025-05-20 5:17 ` Christophe Leroy
2025-05-20 2:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCVNG2lm9x9dzu6x@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=christophe.leroy@csgroup.eu \
--cc=dtsen@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox