* [PATCH -next] chcr: Fix non static symbol warning
@ 2016-08-22 16:11 Wei Yongjun
2016-08-24 13:06 ` Herbert Xu
2016-08-26 14:21 ` [PATCH -next v2] " Wei Yongjun
0 siblings, 2 replies; 6+ messages in thread
From: Wei Yongjun @ 2016-08-22 16:11 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Hariprasad Shenai, Atul Gupta
Cc: Wei Yongjun, linux-crypto
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/crypto/chelsio/chcr_algo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index ad8e353..e4ddb92 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -590,7 +590,7 @@ badkey_err:
return -EINVAL;
}
-int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
+static int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
{
int ret = 0;
struct sge_ofld_txq *q;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] chcr: Fix non static symbol warning
2016-08-22 16:11 [PATCH -next] chcr: Fix non static symbol warning Wei Yongjun
@ 2016-08-24 13:06 ` Herbert Xu
2016-08-24 14:50 ` Wei Yongjun
2016-08-26 14:21 ` [PATCH -next v2] " Wei Yongjun
1 sibling, 1 reply; 6+ messages in thread
From: Herbert Xu @ 2016-08-24 13:06 UTC (permalink / raw)
To: Wei Yongjun
Cc: David S. Miller, Hariprasad Shenai, Atul Gupta, Wei Yongjun,
linux-crypto
On Mon, Aug 22, 2016 at 04:11:18PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Please repost this to netdev as the chelsio patches were applied
in the net tree.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] chcr: Fix non static symbol warning
2016-08-24 13:06 ` Herbert Xu
@ 2016-08-24 14:50 ` Wei Yongjun
2016-08-25 4:22 ` Herbert Xu
0 siblings, 1 reply; 6+ messages in thread
From: Wei Yongjun @ 2016-08-24 14:50 UTC (permalink / raw)
To: Herbert Xu
Cc: David S. Miller, Hariprasad Shenai, Atul Gupta, Wei Yongjun,
linux-crypto
Hi Herbert,
On 08/24/2016 09:06 PM, Herbert Xu wrote:
> On Mon, Aug 22, 2016 at 04:11:18PM +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Fixes the following sparse warning:
>>
>> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
>> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Please repost this to netdev as the chelsio patches were applied
> in the net tree.
This file only exists in net-next, not in netdev.
http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/tree/drivers/crypto/chelsio/chcr_algo.c
show not found.
Regards,
Wei Yongjun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] chcr: Fix non static symbol warning
2016-08-24 14:50 ` Wei Yongjun
@ 2016-08-25 4:22 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2016-08-25 4:22 UTC (permalink / raw)
To: Wei Yongjun
Cc: David S. Miller, Hariprasad Shenai, Atul Gupta, Wei Yongjun,
linux-crypto
On Wed, Aug 24, 2016 at 10:50:24PM +0800, Wei Yongjun wrote:
> Hi Herbert,
>
> On 08/24/2016 09:06 PM, Herbert Xu wrote:
> > On Mon, Aug 22, 2016 at 04:11:18PM +0000, Wei Yongjun wrote:
> >> From: Wei Yongjun <weiyongjun1@huawei.com>
> >>
> >> Fixes the following sparse warning:
> >>
> >> drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
> >> symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
> >>
> >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > Please repost this to netdev as the chelsio patches were applied
> > in the net tree.
>
> This file only exists in net-next, not in netdev.
> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/tree/drivers/crypto/chelsio/chcr_algo.c
> show not found.
I meant the netdev mailing list.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next v2] chcr: Fix non static symbol warning
2016-08-22 16:11 [PATCH -next] chcr: Fix non static symbol warning Wei Yongjun
2016-08-24 13:06 ` Herbert Xu
@ 2016-08-26 14:21 ` Wei Yongjun
2016-08-26 14:42 ` Herbert Xu
1 sibling, 1 reply; 6+ messages in thread
From: Wei Yongjun @ 2016-08-26 14:21 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Hariprasad Shenai, Atul Gupta
Cc: Wei Yongjun, linux-crypto, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/crypto/chelsio/chcr_algo.c:593:5: warning:
symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: cc netdev maillist
---
drivers/crypto/chelsio/chcr_algo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index ad8e353..e4ddb92 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -590,7 +590,7 @@ badkey_err:
return -EINVAL;
}
-int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
+static int cxgb4_is_crypto_q_full(struct net_device *dev, unsigned int idx)
{
int ret = 0;
struct sge_ofld_txq *q;
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-26 14:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-22 16:11 [PATCH -next] chcr: Fix non static symbol warning Wei Yongjun
2016-08-24 13:06 ` Herbert Xu
2016-08-24 14:50 ` Wei Yongjun
2016-08-25 4:22 ` Herbert Xu
2016-08-26 14:21 ` [PATCH -next v2] " Wei Yongjun
2016-08-26 14:42 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox