* [PATCH v2] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
@ 2019-10-22 7:28 Yunfeng Ye
2019-10-22 7:43 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Yunfeng Ye @ 2019-10-22 7:28 UTC (permalink / raw)
To: Herbert Xu, davem, catalin.marinas, will, ard.biesheuvel
Cc: linux-crypto, linux-arm-kernel, linux-kernel, hushiyuan,
linfeilong
A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"
Fix this by adding return value of skcipher_walk_done().
Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()
arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..e3e27349a9fe 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
goto xts_tail;
kernel_neon_end();
- skcipher_walk_done(&walk, nbytes);
+ err = skcipher_walk_done(&walk, nbytes);
}
if (err || likely(!tail))
--
2.7.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
2019-10-22 7:28 [PATCH v2] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() Yunfeng Ye
@ 2019-10-22 7:43 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2019-10-22 7:43 UTC (permalink / raw)
To: Yunfeng Ye
Cc: Herbert Xu, David S. Miller, Catalin Marinas, Will Deacon,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-arm-kernel,
Linux Kernel Mailing List, hushiyuan, linfeilong
On Tue, 22 Oct 2019 at 09:28, Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>
> A warning is found by the static code analysis tool:
> "Identical condition 'err', second condition is always false"
>
> Fix this by adding return value of skcipher_walk_done().
>
> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> v1 -> v2:
> - update the subject and comment
> - add return value of skcipher_walk_done()
>
> arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
> index ea873b8904c4..e3e27349a9fe 100644
> --- a/arch/arm64/crypto/aes-neonbs-glue.c
> +++ b/arch/arm64/crypto/aes-neonbs-glue.c
> @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
> goto xts_tail;
>
> kernel_neon_end();
> - skcipher_walk_done(&walk, nbytes);
> + err = skcipher_walk_done(&walk, nbytes);
> }
>
> if (err || likely(!tail))
> --
> 2.7.4.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-22 7:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-22 7:28 [PATCH v2] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() Yunfeng Ye
2019-10-22 7:43 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox