From: "Adam, Mahmoud" <mngyadam@amazon.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mahmoud Adam <mngyadam@amazon.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] KEYS: use kfree_sensitive with key
Date: Fri, 16 Jun 2023 10:42:44 +0000 [thread overview]
Message-ID: <09E6D7DF-8A97-4E18-BA22-CFEAC430996D@amazon.de> (raw)
In-Reply-To: <ZIw56UTG3fPtp/DM@gondor.apana.org.au>
> On 16. Jun 2023, at 12:31, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Jun 15, 2023 at 12:57:13PM +0000, Mahmoud Adam wrote:
>> key might contain private part of the key, so better use
>> kfree_sensitive to free it
>>
>> Signed-off-by: Mahmoud Adam <mngyadam@amazon.com>
>> ---
>> v2: kfree_sensitive only private key
>>
>> crypto/asymmetric_keys/public_key.c | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> Sorry, I was confused by the naming in this file. These public_keys
> can indeed be private. So I'll just take your original patch.
It’s indeed very confusing.
Thanks for the review.
Mahmoud Adam
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
prev parent reply other threads:[~2023-06-16 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:57 [PATCH v2] KEYS: use kfree_sensitive with key Mahmoud Adam
2023-06-16 10:31 ` Herbert Xu
2023-06-16 10:42 ` Adam, Mahmoud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09E6D7DF-8A97-4E18-BA22-CFEAC430996D@amazon.de \
--to=mngyadam@amazon.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mngyadam@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox