From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mahmoud Adam <mngyadam@amazon.com>
Cc: dhowells@redhat.com, davem@davemloft.net,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KEYS: use kfree_sensitive with key
Date: Fri, 16 Jun 2023 18:31:05 +0800 [thread overview]
Message-ID: <ZIw56UTG3fPtp/DM@gondor.apana.org.au> (raw)
In-Reply-To: <20230615125712.105873-1-mngyadam@amazon.com>
On Thu, Jun 15, 2023 at 12:57:13PM +0000, Mahmoud Adam wrote:
> key might contain private part of the key, so better use
> kfree_sensitive to free it
>
> Signed-off-by: Mahmoud Adam <mngyadam@amazon.com>
> ---
> v2: kfree_sensitive only private key
>
> crypto/asymmetric_keys/public_key.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Sorry, I was confused by the naming in this file. These public_keys
can indeed be private. So I'll just take your original patch.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-06-16 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:57 [PATCH v2] KEYS: use kfree_sensitive with key Mahmoud Adam
2023-06-16 10:31 ` Herbert Xu [this message]
2023-06-16 10:42 ` Adam, Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIw56UTG3fPtp/DM@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mngyadam@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox