* [PATCH] crypto: dcp: Check the return value from devm_ioremap_resource()
@ 2013-09-23 21:12 Fabio Estevam
2013-10-07 7:10 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-09-23 21:12 UTC (permalink / raw)
To: herbert; +Cc: linux-crypto, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
devm_ioremap_resource() may fail, so better check its return value and propagate
it in the case of error.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/crypto/dcp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c
index 7b77c84..247ab80 100644
--- a/drivers/crypto/dcp.c
+++ b/drivers/crypto/dcp.c
@@ -734,6 +734,8 @@ static int dcp_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
dev->dcp_regs_base = devm_ioremap_resource(&pdev->dev, r);
+ if (IS_ERR(dev->dcp_regs_base))
+ return PTR_ERR(dev->dcp_regs_base);
dcp_set(dev, DCP_CTRL_SFRST, DCP_REG_CTRL);
udelay(10);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-07 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 21:12 [PATCH] crypto: dcp: Check the return value from devm_ioremap_resource() Fabio Estevam
2013-10-07 7:10 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox