Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH -next] crypto: api: Do not access module name directly from module structure
Date: Fri, 24 Apr 2015 08:58:03 -0700	[thread overview]
Message-ID: <1429891083-525-1-git-send-email-linux@roeck-us.net> (raw)

'struct module' is only fully declared if CONFIG_MODULES is configured.
If not, the build fails with

crypto/algapi.c: In function 'crypto_check_module_sig':
crypto/algapi.c:49:12: error: dereferencing pointer to incomplete type

Fixes: 59afdc7b3214 ("crypto: api - Move module sig ifdef into accessor
	function")
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Seen in next-20150424.

 crypto/algapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/algapi.c b/crypto/algapi.c
index c63836f4ff64..3103e6a1282e 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -46,7 +46,7 @@ static inline void crypto_check_module_sig(struct module *mod)
 {
 	if (fips_enabled && mod && !module_sig_ok(mod))
 		panic("Module %s signature verification failed in FIPS mode\n",
-		      mod->name);
+		      module_name(mod));
 }
 
 static int crypto_check_alg(struct crypto_alg *alg)
-- 
2.1.0

             reply	other threads:[~2015-04-24 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 15:58 Guenter Roeck [this message]
2015-04-24 22:38 ` [PATCH -next] crypto: api: Do not access module name directly from module structure Herbert Xu
2015-04-24 23:27   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429891083-525-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox