From: Guenter Roeck <linux@roeck-us.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH -next] crypto: api: Do not access module name directly from module structure
Date: Fri, 24 Apr 2015 16:27:52 -0700 [thread overview]
Message-ID: <20150424232752.GA6732@roeck-us.net> (raw)
In-Reply-To: <20150424223803.GB3690@gondor.apana.org.au>
On Sat, Apr 25, 2015 at 06:38:03AM +0800, Herbert Xu wrote:
> On Fri, Apr 24, 2015 at 08:58:03AM -0700, Guenter Roeck wrote:
> > 'struct module' is only fully declared if CONFIG_MODULES is configured.
> > If not, the build fails with
> >
> > crypto/algapi.c: In function 'crypto_check_module_sig':
> > crypto/algapi.c:49:12: error: dereferencing pointer to incomplete type
> >
> > Fixes: 59afdc7b3214 ("crypto: api - Move module sig ifdef into accessor
> > function")
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > Seen in next-20150424.
>
> Thanks but a similar patch has already been queued.
Excellent.
Thanks,
Guenter
prev parent reply other threads:[~2015-04-25 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 15:58 [PATCH -next] crypto: api: Do not access module name directly from module structure Guenter Roeck
2015-04-24 22:38 ` Herbert Xu
2015-04-24 23:27 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424232752.GA6732@roeck-us.net \
--to=linux@roeck-us.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox