Linux cryptographic layer development
 help / color / mirror / Atom feed
* [PATCH] crypto: amcc: Do a NULL check for pointer
@ 2015-08-14  3:05 Fabio Estevam
  2015-08-14  3:08 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-08-14  3:05 UTC (permalink / raw)
  To: herbert; +Cc: linux-crypto, Fabio Estevam

From: Fabio Estevam <fabio.estevam@freescale.com>

Compare pointer-typed values to NULL rather than 0.

The semantic patch that makes this change is available
in scripts/coccinelle/null/badzero.cocci

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/crypto/amcc/crypto4xx_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c
index 3b28e8c..47c4b08 100644
--- a/drivers/crypto/amcc/crypto4xx_core.c
+++ b/drivers/crypto/amcc/crypto4xx_core.c
@@ -1113,7 +1113,7 @@ static irqreturn_t crypto4xx_ce_interrupt_handler(int irq, void *data)
 	struct device *dev = (struct device *)data;
 	struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev);
 
-	if (core_dev->dev->ce_base == 0)
+	if (core_dev->dev->ce_base == NULL)
 		return 0;
 
 	writel(PPC4XX_INTERRUPT_CLR,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: amcc: Do a NULL check for pointer
  2015-08-14  3:05 [PATCH] crypto: amcc: Do a NULL check for pointer Fabio Estevam
@ 2015-08-14  3:08 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-08-14  3:08 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-crypto, Fabio Estevam

On Fri, Aug 14, 2015 at 12:05:58AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Compare pointer-typed values to NULL rather than 0.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/null/badzero.cocci
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/crypto/amcc/crypto4xx_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c
> index 3b28e8c..47c4b08 100644
> --- a/drivers/crypto/amcc/crypto4xx_core.c
> +++ b/drivers/crypto/amcc/crypto4xx_core.c
> @@ -1113,7 +1113,7 @@ static irqreturn_t crypto4xx_ce_interrupt_handler(int irq, void *data)
>  	struct device *dev = (struct device *)data;
>  	struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev);
>  
> -	if (core_dev->dev->ce_base == 0)
> +	if (core_dev->dev->ce_base == NULL)

Please use ! instead.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-14  3:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14  3:05 [PATCH] crypto: amcc: Do a NULL check for pointer Fabio Estevam
2015-08-14  3:08 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox