Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

[Stephan Müller]

Hi Herbert,

I got the attached error report. This is due to CRYPTO_HASH2 is selected as m 
whereas security/keys/dh.c is compiled as y. Note CRYPTO_HASH is selected as 
y.

dh.c requires shash.

Kconfig for dh.c contains:

config KEY_DH_OPERATIONS
       bool "Diffie-Hellman operations on retained keys"
       depends on KEYS
       select MPILIB
       select CRYPTO_HASH


Shall I select CRYPTO_HASH2 instead or in addition to CRYPTO_HASH?

Thanks.

Ciao
Stephan

----------  Weitergeleitete Nachricht  ----------

Betreff: [linux-next:master 7274/8070] undefined reference to 
`crypto_alloc_shash'
Datum: Donnerstag, 6. April 2017, 10:03:30 CEST
Von: kbuild test robot <fengguang.wu@intel.com>
An: Stephan Mueller <smueller@chronox.de>
Kopie: kbuild-all@01.org, David Howells <dhowells@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
master
head:   d203084e692ac2f656cf8c50449f8f90ca7875de
commit: f1c316a3ab9d24df6022682422fe897492f2c0c8 [7274/8070] KEYS: add 
SP800-56A KDF support for DH
config: x86_64-randconfig-s0-04061437 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout f1c316a3ab9d24df6022682422fe897492f2c0c8
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   security/built-in.o: In function `__keyctl_dh_compute':
>> (.text+0xa4f7): undefined reference to `crypto_alloc_shash'
   security/built-in.o: In function `__keyctl_dh_compute':
>> (.text+0xa7b5): undefined reference to `crypto_shash_update'
   security/built-in.o: In function `__keyctl_dh_compute':
   (.text+0xa7ed): undefined reference to `crypto_shash_update'
   security/built-in.o: In function `__keyctl_dh_compute':
>> (.text+0xa832): undefined reference to `crypto_shash_final'
   security/built-in.o: In function `__keyctl_dh_compute':
   (.text+0xa881): undefined reference to `crypto_shash_final'
   security/built-in.o: In function `__keyctl_dh_compute':
>> (.text+0xa9bd): undefined reference to `crypto_destroy_tfm'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

-------------------------------------------------------------

Re: Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

[Herbert Xu]

On Sun, Apr 09, 2017 at 10:09:54PM +0200, Stephan Müller wrote:
> Hi Herbert,
> 
> I got the attached error report. This is due to CRYPTO_HASH2 is selected as m 
> whereas security/keys/dh.c is compiled as y. Note CRYPTO_HASH is selected as 
> y.

Hmm that's weird because CRYPTO_HASH selects CRYPTO_HASH2.  Do
you have a kconfig file that reproduces this?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

[Stephan Müller]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Am Montag, 10. April 2017, 12:22:23 CEST schrieb Herbert Xu:

Hi Herbert,

> Hmm that's weird because CRYPTO_HASH selects CRYPTO_HASH2.  Do
> you have a kconfig file that reproduces this?

Please see attached.

Thanks

Ciao
Stephan

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25410 bytes --]

Re: Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

[Herbert Xu]

On Mon, Apr 10, 2017 at 12:46:22PM +0200, Stephan Müller wrote:
> Am Montag, 10. April 2017, 12:22:23 CEST schrieb Herbert Xu:
> 
> Hi Herbert,
> 
> > Hmm that's weird because CRYPTO_HASH selects CRYPTO_HASH2.  Do
> > you have a kconfig file that reproduces this?
> 
> Please see attached.

I see the problem.  When you select CRYPTO_HASH you must also
select CRYPTO.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

[Stephan Müller]

Am Dienstag, 11. April 2017, 12:50:00 CEST schrieb Herbert Xu:

Hi Herbert,

> I see the problem.  When you select CRYPTO_HASH you must also
> select CRYPTO.

Thank you very much.

I will prepare a patch.

Ciao
Stephan