From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Patrick McHardy <kaber@trash.net>
Cc: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [HIFN 03/n]: Indicate asynchronous processing to crypto API
Date: Wed, 7 May 2008 16:23:08 +0400 [thread overview]
Message-ID: <20080507122307.GA17128@2ka.mipt.ru> (raw)
In-Reply-To: <48219E58.4000503@trash.net>
Hi.
On Wed, May 07, 2008 at 02:19:36PM +0200, Patrick McHardy (kaber@trash.net) wrote:
> hifn_setup_crypto() needs to return -EINPROGRESS on success to indicate
> asynchronous processing to the crypto API. This also means it must not
> return the errno code returned by hifn_process_queue(), if any.
Then how to indicate that error occured?
What if we will return -EINPROGRESS in case of success and negative
errno otherwise?
> @@ -2202,9 +2202,9 @@ static int hifn_setup_crypto(struct ablkcipher_request *req, u8 op,
> return err;
>
> if (dev->started < HIFN_QUEUE_LENGTH && dev->queue.qlen)
> - err = hifn_process_queue(dev);
> + hifn_process_queue(dev);
>
> - return err;
> + return -EINPROGRESS;
Thus we are not able to return any error at all...
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-05-07 12:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 12:14 [HIFN 01/n]: Endianess fixes Patrick McHardy
2008-05-07 12:15 ` [HIFN 02/n]: Remove printk_ratelimit() for debugging printk Patrick McHardy
2008-05-07 12:23 ` Evgeniy Polyakov
2008-05-07 12:19 ` [HIFN 03/n]: Indicate asynchronous processing to crypto API Patrick McHardy
2008-05-07 12:23 ` Evgeniy Polyakov [this message]
2008-05-07 12:29 ` Patrick McHardy
2008-05-07 12:20 ` [HIFN 04/n]: Handle ablkcipher_walk errors Patrick McHardy
2008-05-07 12:44 ` Evgeniy Polyakov
2008-05-07 12:26 ` [HIFN 05/n]: Fix data alignment checks Patrick McHardy
2008-05-07 12:42 ` Evgeniy Polyakov
2008-05-07 12:45 ` Patrick McHardy
2008-05-07 13:04 ` Evgeniy Polyakov
2008-05-07 13:05 ` Patrick McHardy
2008-05-07 13:22 ` Evgeniy Polyakov
2008-05-07 12:48 ` Herbert Xu
2008-05-07 12:51 ` Patrick McHardy
2008-05-07 12:30 ` [HIFN 06/n]: Properly handle requests for less than the full scatterlist Patrick McHardy
2008-05-07 13:01 ` Evgeniy Polyakov
2008-05-07 12:32 ` [HIFN 07/n]: Use unique driver names for different algos Patrick McHardy
2008-05-07 13:07 ` Evgeniy Polyakov
2008-05-07 12:36 ` [HIFN 08/n]: Properly initialize ivsize for CBC modes Patrick McHardy
2008-05-07 12:38 ` [HIFN 09/n]: Fix max queue length value Patrick McHardy
2008-05-07 12:46 ` Evgeniy Polyakov
2008-05-07 12:50 ` [HIFN 10/n]: Move command descriptor setup to seperate function Patrick McHardy
2008-05-07 13:11 ` Evgeniy Polyakov
2008-05-07 12:53 ` [HIFN 11/n]: Have HW invalidate src and dest descriptors after processing Patrick McHardy
2008-05-07 13:14 ` Evgeniy Polyakov
2008-05-07 13:18 ` Patrick McHardy
2008-05-07 13:00 ` [HIFN 01/n]: Endianess fixes Evgeniy Polyakov
2008-05-07 13:01 ` Patrick McHardy
2008-05-07 13:23 ` Evgeniy Polyakov
2008-05-07 13:46 ` Patrick McHardy
2008-05-07 14:04 ` Evgeniy Polyakov
2008-05-07 14:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507122307.GA17128@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox