Re: [HIFN 11/n]: Have HW invalidate src and dest descriptors after processing

[Patrick McHardy <kaber@trash.net>]

Evgeniy Polyakov wrote:
> On Wed, May 07, 2008 at 02:53:17PM +0200, Patrick McHardy (kaber@trash.net) wrote:
>>     The descriptors need to be invalidated after processing for ring
>>     cleanup to work properly and to avoid using an old destination
>>     descriptor when the src and cmd descriptors are already set up
>>     and the dst descriptor isn't.
>>     
>>     Signed-off-by: Patrick McHardy <kaber@trash.net>
> 
> Well, we only care about cmd register and do not process valid bit in
> others, instead of cmd is not valid we do not use others, but we can
> also check other descriptors too.

I noticed the ring cleanup debugging printing ever increasing
use counts for src and dst descriptors, which went away with
this patch, but the more important point is avoiding that the
HW accidentally uses an old descriptors of course.

> Thanks Patrick, I have no objections.

Thanks Evgeniy. Thats it for now, next round will take until
tonight or maybe tommorrow.