From: Herbert Xu <herbert@gondor.apana.org.au>
To: Loc Ho <lho@amcc.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: IPSec ESP Authenc Offload
Date: Thu, 29 May 2008 17:01:30 +1000 [thread overview]
Message-ID: <20080529070130.GC18007@gondor.apana.org.au> (raw)
In-Reply-To: <0CA0A16855646F4FA96D25A158E299D604815113@SDCEXCHANGE01.ad.amcc.com>
On Wed, May 28, 2008 at 04:02:11PM -0700, Loc Ho wrote:
>
> It doesn't help if it is generated by software. The driver still needs a
> context SA for each operation. In addition, the driver will have to
> increment seq (or load from request) and load SEQ and IV into each
> context SA. It is much cleaner if our driver knows the whole header
> length. Even if the hardware rewrites the SPI and SEQ again, it is all
> handled by hardware offload and will not be a problem for IPSEC ESP.
I'm happy to add support for ESP offload. However, I don't think
we should add it onto the AEAD interface. We should instead create
an ESP interface that specifically does this.
I still think that you can use the existing interface though and
just throw away the ESP work since that's trivial anyway. Having
a context SA is not a problem since each tfm corresponds to a single
SA and you can just store the context in its context area.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2008-05-29 7:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 11:32 [PATCH] CRYPTO: Simplify code using ARRAY_SIZE() macro Robert P. J. Day
2008-05-26 11:20 ` Herbert Xu
2008-05-27 8:50 ` Robert P. J. Day
2008-05-27 18:29 ` IPSec ESP Authenc Offload Loc Ho
2008-05-28 6:34 ` Herbert Xu
2008-05-28 16:42 ` Loc Ho
2008-05-28 22:22 ` Herbert Xu
2008-05-28 23:02 ` Loc Ho
2008-05-29 7:01 ` Herbert Xu [this message]
2008-05-29 17:44 ` Loc Ho
2008-05-29 23:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529070130.GC18007@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=lho@amcc.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox