Re: [PATCH] CRYPTO: Simplify code using ARRAY_SIZE() macro.

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Mon, 26 May 2008, Herbert Xu wrote:

> On Sun, May 25, 2008 at 11:32:45AM +0000, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
> > index 81f3f95..c4c018d 100644
> > --- a/drivers/crypto/hifn_795x.c
> > +++ b/drivers/crypto/hifn_795x.c
> > @@ -894,7 +894,7 @@ static int hifn_enable_crypto(struct hifn_device *dev)
> >  	char *offtbl = NULL;
> >  	int i;
> >
> > -	for (i = 0; i < sizeof(pci2id)/sizeof(pci2id[0]); i++) {
> > +	for (i = 0; i < ARRAY_SIZE(pci2id)); i++) {
>
> You've got an extra parenthesis here.  You should be building the
> patches that you send, no matter how trivial they might look!
>
> I've fixed it for you this time.

yes, my apologies.  thanks.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================