From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev@ozlabs.org, mr.scada@gmail.com,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver
Date: Sat, 31 May 2008 01:12:08 +0400 [thread overview]
Message-ID: <20080530211204.GA15768@2ka.mipt.ru> (raw)
In-Reply-To: <20080530154820.6e56b625.kim.phillips@freescale.com>
On Fri, May 30, 2008 at 03:48:20PM -0500, Kim Phillips (kim.phillips@freescale.com) wrote:
> sorry, by ISR I meant interrupt status registers. but I can't tell
> where the suspected simultaneous accesses are. Evgeniy, can you point
> out the register accesses you're talking about?
priv->status is accessed from tasklets, although readonly, but that rises
a red flag... Also callback invocation tasklet drops the lock around
callback, during that time cached status and priv itself (and tail like
in two simultaneous flushes) could change (or not?)
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-05-30 21:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 19:12 [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver Kim Phillips
2008-05-30 18:09 ` Evgeniy Polyakov
2008-05-30 19:36 ` Kim Phillips
2008-05-30 19:41 ` Scott Wood
2008-05-30 20:13 ` Evgeniy Polyakov
2008-05-30 20:16 ` Kim Phillips
2008-05-30 20:19 ` Scott Wood
2008-05-30 20:35 ` Kim Phillips
2008-05-30 20:36 ` Scott Wood
2008-05-30 20:48 ` Kim Phillips
2008-05-30 21:12 ` Evgeniy Polyakov [this message]
2008-05-30 22:19 ` Kim Phillips
2008-05-31 9:59 ` Evgeniy Polyakov
2008-06-02 14:27 ` Kim Phillips
2008-06-02 16:00 ` Evgeniy Polyakov
2008-06-02 16:50 ` Kim Phillips
2008-06-02 17:57 ` Evgeniy Polyakov
2008-06-02 19:06 ` Kim Phillips
2008-06-03 1:24 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530211204.GA15768@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=herbert@gondor.apana.org.au \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mr.scada@gmail.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox