Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: James Hsiao <jhsiao@amcc.com>
Cc: kim.phillips@freescale.com, jwboyer@linux.vnet.ibm.com,
	linux-crypto@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] AMCC Crypto4xx Device Driver v5
Date: Wed, 28 Jan 2009 14:59:37 +1100	[thread overview]
Message-ID: <20090128035937.GA13157@gondor.apana.org.au> (raw)
In-Reply-To: <1231788650.5533.16.camel@jhsiao-usb>

On Mon, Jan 12, 2009 at 11:30:50AM -0800, James Hsiao wrote:
> This is the 5th submission of AMCC's security driver.
> - remove aad support in build pd function, since we didn't release any
> algorithm that use aead yet.
> 
> - changed some hardcode value to #defines
> 
> - changed local_irq_disable/enable to spinlock_irq_save/restore
> 
> - fixed bug in crypto4xx_probe on error exit.
> 
> 
> Signed-off-by: James Hsiao <jhsiao@amcc.com>

I was going to apply this but you didn't give me a changelog
that I can throw into the tree without feeling guilty!

Please always attach a proper changelog with each submission
so I don't have to do this.  You can put the changelog elsewhere
in the email.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2009-01-28  3:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 19:30 [PATCH] AMCC Crypto4xx Device Driver v5 James Hsiao
2009-01-28  3:59 ` Herbert Xu [this message]
2009-01-28 17:41   ` James Hsiao
2009-01-28 21:29     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090128035937.GA13157@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=jhsiao@amcc.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=kim.phillips@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox