From: Herbert Xu <herbert@gondor.apana.org.au>
To: James Hsiao <jhsiao@amcc.com>
Cc: kim.phillips@freescale.com, jwboyer@linux.vnet.ibm.com,
linux-crypto@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] AMCC Crypto4xx Device Driver v5
Date: Thu, 29 Jan 2009 08:29:08 +1100 [thread overview]
Message-ID: <20090128212908.GC22141@gondor.apana.org.au> (raw)
In-Reply-To: <1233164516.4809.9.camel@jhsiao-usb>
On Wed, Jan 28, 2009 at 09:41:56AM -0800, James Hsiao wrote:
>
> I will re submit the patch with proper changelog.
> I had the change log this way is for the reviewer easy to see the
> difference. But, I agree this is not proper for a newly created driver.
Oh yeah I have nothing against the changelog you had but it should
be present along with the patch description so it can actually
be applied.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2009-01-28 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 19:30 [PATCH] AMCC Crypto4xx Device Driver v5 James Hsiao
2009-01-28 3:59 ` Herbert Xu
2009-01-28 17:41 ` James Hsiao
2009-01-28 21:29 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128212908.GC22141@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jhsiao@amcc.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox