unmet direct dependencies (CRYPTO && EXPERIMENTAL)

unmet direct dependencies (CRYPTO && EXPERIMENTAL)

[Toralf Förster]

Hello,

a "make randconfig 1>/dev/null" gave today :

warning: (CRYPTO_LRW && CRYPTO && EXPERIMENTAL || CRYPTO_XTS && CRYPTO && EXPERIMENTAL || CRYPTO_GHASH && CRYPTO) selects 
CRYPTO_GF128MUL which has unmet direct dependencies (CRYPTO && EXPERIMENTAL)

for the current git kernel sources.
Is this an already known issue ?

-- 
MfG/Kind regards
Toralf Förster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Re: unmet direct dependencies (CRYPTO && EXPERIMENTAL)

[Herbert Xu]

Toralf Förster <toralf.foerster@gmx.de> wrote:
> 
> a "make randconfig 1>/dev/null" gave today :
> 
> warning: (CRYPTO_LRW && CRYPTO && EXPERIMENTAL || CRYPTO_XTS && CRYPTO && EXPERIMENTAL || CRYPTO_GHASH && CRYPTO) selects 
> CRYPTO_GF128MUL which has unmet direct dependencies (CRYPTO && EXPERIMENTAL)
> 
> for the current git kernel sources.
> Is this an already known issue ?

Does this patch help?

commit 8ad225e8e4f530f500c12ec77fd5a51caf6a2f66
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Tue Dec 28 22:56:26 2010 +1100

    crypto: gf128mul - Remove experimental tag
    
    This feature no longer needs the experimental tag.
    
    Reported-by: Toralf Förster <toralf.foerster@gmx.de>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 96b0e55..4b7cb0e 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -110,7 +110,6 @@ config CRYPTO_MANAGER_DISABLE_TESTS
 
 config CRYPTO_GF128MUL
 	tristate "GF(2^128) multiplication functions (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
 	help
 	  Efficient table driven implementation of multiplications in the
 	  field GF(2^128).  This is needed by some cypher modes. This

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: unmet direct dependencies (CRYPTO && EXPERIMENTAL)

[Toralf Förster]

Herbert Xu wrote at 12:58:26
> Toralf Förster <toralf.foerster@gmx.de> wrote:
> > a "make randconfig 1>/dev/null" gave today :
> > 
> > warning: (CRYPTO_LRW && CRYPTO && EXPERIMENTAL || CRYPTO_XTS && CRYPTO &&
> > EXPERIMENTAL || CRYPTO_GHASH && CRYPTO) selects CRYPTO_GF128MUL which
> > has unmet direct dependencies (CRYPTO && EXPERIMENTAL)
> > 
> > for the current git kernel sources.
> > Is this an already known issue ?
> 
> Does this patch help?

Althought I did not have the original .config, I'm pretty sure this patch 
helps b/c after I applied it, the issue wasn't any longer observed even doing 
*a lot* of "make randconfig"..

> commit 8ad225e8e4f530f500c12ec77fd5a51caf6a2f66
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Tue Dec 28 22:56:26 2010 +1100
> 
>     crypto: gf128mul - Remove experimental tag
> 
>     This feature no longer needs the experimental tag.
> 
>     Reported-by: Toralf Förster <toralf.foerster@gmx.de>
>     Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 96b0e55..4b7cb0e 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -110,7 +110,6 @@ config CRYPTO_MANAGER_DISABLE_TESTS
> 
>  config CRYPTO_GF128MUL
>  	tristate "GF(2^128) multiplication functions (EXPERIMENTAL)"
> -	depends on EXPERIMENTAL
>  	help
>  	  Efficient table driven implementation of multiplications in the
>  	  field GF(2^128).  This is needed by some cypher modes. This
> 
> Thanks,


-- 
MfG/Kind regards
Toralf Förster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3