Linux cryptographic layer development
 help / color / mirror / Atom feed
* [PATCH -next] crypto: fix aesni build on i386
       [not found] <20110517142749.8927b65b.sfr@canb.auug.org.au>
@ 2011-05-17 18:52 ` Randy Dunlap
  2011-05-17 23:03   ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2011-05-17 18:52 UTC (permalink / raw)
  To: Stephen Rothwell, Herbert Xu, davem, Huang Ying
  Cc: linux-next, LKML, linux-crypto

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix build error on i386 by moving function prototypes:

arch/x86/crypto/aesni-intel_glue.c: In function 'aesni_init':
arch/x86/crypto/aesni-intel_glue.c:1263: error: implicit declaration of function 'crypto_fpu_init'
arch/x86/crypto/aesni-intel_glue.c: In function 'aesni_exit':
arch/x86/crypto/aesni-intel_glue.c:1373: error: implicit declaration of function 'crypto_fpu_exit'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 arch/x86/crypto/aesni-intel_glue.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

These function prototypes should preferably be in a header file somewhere.

--- linux-next-20110517.orig/arch/x86/crypto/aesni-intel_glue.c
+++ linux-next-20110517/arch/x86/crypto/aesni-intel_glue.c
@@ -94,6 +94,10 @@ asmlinkage void aesni_cbc_enc(struct cry
 			      const u8 *in, unsigned int len, u8 *iv);
 asmlinkage void aesni_cbc_dec(struct crypto_aes_ctx *ctx, u8 *out,
 			      const u8 *in, unsigned int len, u8 *iv);
+
+int crypto_fpu_init(void);
+void crypto_fpu_exit(void);
+
 #ifdef CONFIG_X86_64
 asmlinkage void aesni_ctr_enc(struct crypto_aes_ctx *ctx, u8 *out,
 			      const u8 *in, unsigned int len, u8 *iv);
@@ -140,9 +144,6 @@ asmlinkage void aesni_gcm_dec(void *ctx,
 			u8 *hash_subkey, const u8 *aad, unsigned long aad_len,
 			u8 *auth_tag, unsigned long auth_tag_len);
 
-int crypto_fpu_init(void);
-void crypto_fpu_exit(void);
-
 static inline struct
 aesni_rfc4106_gcm_ctx *aesni_rfc4106_gcm_ctx_get(struct crypto_aead *tfm)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] crypto: fix aesni build on i386
  2011-05-17 18:52 ` [PATCH -next] crypto: fix aesni build on i386 Randy Dunlap
@ 2011-05-17 23:03   ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2011-05-17 23:03 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Stephen Rothwell, davem, Huang Ying, linux-next, LKML,
	linux-crypto

On Tue, May 17, 2011 at 11:52:45AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix build error on i386 by moving function prototypes:
> 
> arch/x86/crypto/aesni-intel_glue.c: In function 'aesni_init':
> arch/x86/crypto/aesni-intel_glue.c:1263: error: implicit declaration of function 'crypto_fpu_init'
> arch/x86/crypto/aesni-intel_glue.c: In function 'aesni_exit':
> arch/x86/crypto/aesni-intel_glue.c:1373: error: implicit declaration of function 'crypto_fpu_exit'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied.  Thanks Randy!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-17 23:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20110517142749.8927b65b.sfr@canb.auug.org.au>
2011-05-17 18:52 ` [PATCH -next] crypto: fix aesni build on i386 Randy Dunlap
2011-05-17 23:03   ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox