* [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1
@ 2011-10-10 9:32 Jussi Kivilinna
2011-10-21 12:17 ` Herbert Xu
2011-10-21 12:39 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Jussi Kivilinna @ 2011-10-10 9:32 UTC (permalink / raw)
To: linux-crypto; +Cc: Herbert Xu, David S. Miller
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
---
arch/x86/crypto/blowfish_glue.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/crypto/blowfish_glue.c b/arch/x86/crypto/blowfish_glue.c
index 40911ab..dd3964a 100644
--- a/arch/x86/crypto/blowfish_glue.c
+++ b/arch/x86/crypto/blowfish_glue.c
@@ -423,7 +423,7 @@ static struct crypto_alg blk_ctr_alg = {
.cra_driver_name = "ctr-blowfish-asm",
.cra_priority = 300,
.cra_flags = CRYPTO_ALG_TYPE_BLKCIPHER,
- .cra_blocksize = BF_BLOCK_SIZE,
+ .cra_blocksize = 1,
.cra_ctxsize = sizeof(struct bf_ctx),
.cra_alignmask = 0,
.cra_type = &crypto_blkcipher_type,
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1
2011-10-10 9:32 [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1 Jussi Kivilinna
@ 2011-10-21 12:17 ` Herbert Xu
2011-10-21 12:19 ` Herbert Xu
2011-10-21 12:39 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2011-10-21 12:17 UTC (permalink / raw)
To: Jussi Kivilinna; +Cc: linux-crypto, David S. Miller
On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote:
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
What is the rationale for this? Blowfish is not a stream cipher.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1
2011-10-21 12:17 ` Herbert Xu
@ 2011-10-21 12:19 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2011-10-21 12:19 UTC (permalink / raw)
To: Jussi Kivilinna; +Cc: linux-crypto, David S. Miller
On Fri, Oct 21, 2011 at 02:17:49PM +0200, Herbert Xu wrote:
> On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote:
> > Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
>
> What is the rationale for this? Blowfish is not a stream cipher.
Scratch that, I missed the bit about ctr.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1
2011-10-10 9:32 [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1 Jussi Kivilinna
2011-10-21 12:17 ` Herbert Xu
@ 2011-10-21 12:39 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2011-10-21 12:39 UTC (permalink / raw)
To: Jussi Kivilinna; +Cc: linux-crypto, David S. Miller
On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote:
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-21 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 9:32 [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1 Jussi Kivilinna
2011-10-21 12:17 ` Herbert Xu
2011-10-21 12:19 ` Herbert Xu
2011-10-21 12:39 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox