From: Andrew Lunn <andrew@lunn.ch>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Herbert Xu' <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org,
"'David S. Miller'" <davem@davemloft.net>,
'Phil Sutter' <phil.sutter@viprinet.com>,
'Andrew Lunn' <andrew@lunn.ch>
Subject: Re: [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata()
Date: Mon, 6 May 2013 07:12:01 +0200 [thread overview]
Message-ID: <20130506051201.GD2824@lunn.ch> (raw)
In-Reply-To: <002501ce4a0c$994cc010$cbe64030$@samsung.com>
On Mon, May 06, 2013 at 12:48:41PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/crypto/mv_cesa.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
> index ce6290e..3374a3e 100644
> --- a/drivers/crypto/mv_cesa.c
> +++ b/drivers/crypto/mv_cesa.c
> @@ -1146,7 +1146,6 @@ err_unmap_reg:
> err:
> kfree(cp);
> cpg = NULL;
> - platform_set_drvdata(pdev, NULL);
> return ret;
> }
>
Acked-by: Andrew Lunn <andrew@lunn.ch>
prev parent reply other threads:[~2013-05-06 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 3:48 [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 5:12 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506051201.GD2824@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jg1.han@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=phil.sutter@viprinet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox