* [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:48 Jingoo Han
2013-05-06 5:12 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 3:48 UTC (permalink / raw)
To: 'Herbert Xu'
Cc: linux-crypto, 'David S. Miller', 'Jingoo Han',
'Phil Sutter', 'Andrew Lunn'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/crypto/mv_cesa.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
index ce6290e..3374a3e 100644
--- a/drivers/crypto/mv_cesa.c
+++ b/drivers/crypto/mv_cesa.c
@@ -1146,7 +1146,6 @@ err_unmap_reg:
err:
kfree(cp);
cpg = NULL;
- platform_set_drvdata(pdev, NULL);
return ret;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata()
2013-05-06 3:48 [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 5:12 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2013-05-06 5:12 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Herbert Xu', linux-crypto, 'David S. Miller',
'Phil Sutter', 'Andrew Lunn'
On Mon, May 06, 2013 at 12:48:41PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/crypto/mv_cesa.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
> index ce6290e..3374a3e 100644
> --- a/drivers/crypto/mv_cesa.c
> +++ b/drivers/crypto/mv_cesa.c
> @@ -1146,7 +1146,6 @@ err_unmap_reg:
> err:
> kfree(cp);
> cpg = NULL;
> - platform_set_drvdata(pdev, NULL);
> return ret;
> }
>
Acked-by: Andrew Lunn <andrew@lunn.ch>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 5:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 3:48 [PATCH 1/2] crypto: mv_cesa: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 5:12 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox