From: David Miller <davem@davemloft.net>
To: geyslan@gmail.com
Cc: kernel-br@googlegroups.com, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: n2_core: insert '!err' condition in else scope
Date: Sat, 19 Oct 2013 18:49:19 -0400 (EDT) [thread overview]
Message-ID: <20131019.184919.1292439830365652584.davem@davemloft.net> (raw)
In-Reply-To: <CAGG-pUSMJTbGHEhCOy0PRLNN4+jyVB8oB3mca1O9sb2YbpQ-fg@mail.gmail.com>
From: Geyslan Gregório Bem <geyslan@gmail.com>
Date: Sat, 19 Oct 2013 19:42:35 -0300
> 2013/10/19 David Miller <davem@davemloft.net>:
>> From: "Geyslan G. Bem" <geyslan@gmail.com>
>> Date: Sat, 19 Oct 2013 10:09:31 -0300
>>
>>> This patch moves the '!err' condition into the above else scope,
>>> what is more obvious and has the secondary goal of avoid false-positives
>>> in statical analyze tools.
>>>
>>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>>
>> I do not think patches should be applied to satisfy tools if the
>> code is semantically correct.
>
> Yes, Miller, I agree. But as I mentioned:
> ".. and has as the 'secondary' goal of avoid false-positives in
> statical analyze tools."
>
> The 'primary' goal is to not repeat a condition test:
> "This patch moves the '!err' condition into the above else scope, what
> is more obvious ..."
I still do not feel that this change is a net-positive. Sorry.
next prev parent reply other threads:[~2013-10-19 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 13:09 [PATCH] crypto: n2_core: insert '!err' condition in else scope Geyslan G. Bem
2013-10-19 22:38 ` David Miller
2013-10-19 22:42 ` Geyslan Gregório Bem
2013-10-19 22:49 ` David Miller [this message]
2013-10-19 23:13 ` Geyslan Gregório Bem
2013-10-20 12:12 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131019.184919.1292439830365652584.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geyslan@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-br@googlegroups.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox