From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Geyslan Gregório Bem" <geyslan@gmail.com>
Cc: David Miller <davem@davemloft.net>,
kernel-br <kernel-br@googlegroups.com>,
"open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: n2_core: insert '!err' condition in else scope
Date: Sun, 20 Oct 2013 20:12:31 +0800 [thread overview]
Message-ID: <20131020121231.GA20425@gondor.apana.org.au> (raw)
In-Reply-To: <CAGG-pUSfA7ynQM3OEFqHaac3vh3BooisGq2rKO5OmAE_cdKb9A@mail.gmail.com>
On Sat, Oct 19, 2013 at 08:13:25PM -0300, Geyslan Gregório Bem wrote:
>
> I can understand you. You don't want to break your git history
> (blame). But when a code is clearly more readable/understandable you
> must assume that it has a huge net-positive.
>
> The patch improves the code in three ways:
> - Only one if/else;
> - Not blame on static analysis tools.
> - And avoid more discussion about that in the future (nobody will send
> patches like this to disturb you about that part of code).
>
> The decision is yours.
FWIW I totally agree with David so your patch isn't going in.
Sorry.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2013-10-20 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 13:09 [PATCH] crypto: n2_core: insert '!err' condition in else scope Geyslan G. Bem
2013-10-19 22:38 ` David Miller
2013-10-19 22:42 ` Geyslan Gregório Bem
2013-10-19 22:49 ` David Miller
2013-10-19 23:13 ` Geyslan Gregório Bem
2013-10-20 12:12 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020121231.GA20425@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=geyslan@gmail.com \
--cc=kernel-br@googlegroups.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox