From: Borislav Petkov <bp@alien8.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v1] crypto: aesni - fix build on x86 (32bit)
Date: Mon, 6 Jan 2014 21:26:40 +0100 [thread overview]
Message-ID: <20140106202640.GB17863@pd.tnic> (raw)
In-Reply-To: <1389031855.2624.26.camel@schen9-DESK>
On Mon, Jan 06, 2014 at 10:10:55AM -0800, Tim Chen wrote:
> Yes, the code is in the file named aesni_intel_avx.S. So it should be
> clear that the code is meant for x86_64.
How do you deduce aesni_intel_avx.S is meant for x86_64 only from the
name?
Shouldn't it be called aesni_intel_avx-x86_64.S, as is the naming
convention in arch/x86/crypto/
?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-01-06 21:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 13:52 [PATCH v1] crypto: aesni - fix build on x86 (32bit) Andy Shevchenko
2013-12-31 11:57 ` Herbert Xu
2014-01-06 17:41 ` Tim Chen
2014-01-06 17:45 ` H. Peter Anvin
2014-01-06 17:57 ` Tim Chen
2014-01-06 18:00 ` H. Peter Anvin
2014-01-06 18:10 ` Tim Chen
2014-01-06 20:26 ` Borislav Petkov [this message]
2014-01-06 21:21 ` H. Peter Anvin
2014-01-06 23:39 ` Tim Chen
2014-01-06 23:41 ` H. Peter Anvin
2014-01-07 1:30 ` Herbert Xu
2014-01-09 9:03 ` Herbert Xu
2014-01-09 16:57 ` Tim Chen
2014-01-15 3:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106202640.GB17863@pd.tnic \
--to=bp@alien8.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox