Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v1] crypto: aesni - fix build on x86 (32bit)
Date: Mon, 06 Jan 2014 10:00:53 -0800	[thread overview]
Message-ID: <52CAEF55.5090308@zytor.com> (raw)
In-Reply-To: <1389031023.2624.21.camel@schen9-DESK>

On 01/06/2014 09:57 AM, Tim Chen wrote:
> On Mon, 2014-01-06 at 09:45 -0800, H. Peter Anvin wrote:
>> Can the code be adjusted to compile for 32 bit x86 or is that pointless?
>>
> 
> Code was optimized for wide registers.  So it is only meant for x86_64.
> 

Aren't the "wide registers" the vector registers?  Or are you also
relying on 64-bit integer registers (in which case we should just rename
the file to make it clear it is x86-64 only.)

	-hpa

  reply	other threads:[~2014-01-06 18:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 13:52 [PATCH v1] crypto: aesni - fix build on x86 (32bit) Andy Shevchenko
2013-12-31 11:57 ` Herbert Xu
2014-01-06 17:41 ` Tim Chen
2014-01-06 17:45   ` H. Peter Anvin
2014-01-06 17:57     ` Tim Chen
2014-01-06 18:00       ` H. Peter Anvin [this message]
2014-01-06 18:10         ` Tim Chen
2014-01-06 20:26           ` Borislav Petkov
2014-01-06 21:21             ` H. Peter Anvin
2014-01-06 23:39               ` Tim Chen
2014-01-06 23:41                 ` H. Peter Anvin
2014-01-07  1:30                   ` Herbert Xu
2014-01-09  9:03                 ` Herbert Xu
2014-01-09 16:57                   ` Tim Chen
2014-01-15  3:43                     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CAEF55.5090308@zytor.com \
    --to=hpa@zytor.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox