From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"David S.Miller" <davem@davemloft.net>,
Chandramouli Narayanan <mouli@linux.intel.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk
Date: Wed, 23 Jul 2014 21:09:45 +0800 [thread overview]
Message-ID: <20140723130945.GA29178@gondor.apana.org.au> (raw)
In-Reply-To: <1405034288.2970.647.camel@schen9-DESK>
On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote:
> For the special case when we have a null input string, we want
> to initialize the entry len to 0 for the hash/ahash walk, so
> cyrpto_hash_walk_last will return the correct result indicating
> that we have completed the scatter list walk. Otherwise we may
> keep walking the sg list and access bogus memory address.
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
Sorry but which driver is broken by this?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2014-07-23 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 23:18 [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk Tim Chen
2014-07-23 13:09 ` Herbert Xu [this message]
2014-07-23 16:07 ` Tim Chen
2014-08-01 14:18 ` Herbert Xu
2014-08-11 20:32 ` Tim Chen
2014-08-12 12:00 ` Herbert Xu
2014-08-25 12:40 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723130945.GA29178@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=mouli@linux.intel.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox