Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk

[Herbert Xu <herbert@gondor.apana.org.au>]

On Wed, Jul 23, 2014 at 09:07:45AM -0700, Tim Chen wrote:
> On Wed, 2014-07-23 at 21:09 +0800, Herbert Xu wrote:
> > On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote:
> > > For the special case when we have a null input string, we want
> > > to initialize the entry len to 0 for the hash/ahash walk, so
> > > cyrpto_hash_walk_last will return the correct result indicating
> > > that we have completed the scatter list walk.  Otherwise we may
> > > keep walking the sg list and access bogus memory address.
> > > 
> > > Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
> > 
> > Sorry but which driver is broken by this?
> > 
> 
> I haven't tested other driver, but I see this problem when
> I was testing the new multi-buffer sha1 driver

OK, I'll add this patch along with the rest of your series then.
I thought it affected existing drivers but it seems that it's
only your driver that's affected.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt