From: Theodore Ts'o <tytso@mit.edu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stephan Mueller <smueller@chronox.de>,
pebolle@tiscali.nl, andreas.steffen@strongswan.org,
sandyinchina@gmail.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: random: Wake up all getrandom(2) callers when pool is ready
Date: Thu, 21 May 2015 15:17:39 -0400 [thread overview]
Message-ID: <20150521191739.GP2871@thunk.org> (raw)
In-Reply-To: <20150521081953.GA22301@gondor.apana.org.au>
On Thu, May 21, 2015 at 04:19:54PM +0800, Herbert Xu wrote:
> On Thu, May 21, 2015 at 09:55:17AM +0200, Stephan Mueller wrote:
> >
> > So, I will create a 2nd wait queue in random.c for uninterruptible waits,
> > change the get_blocking_random_bytes back to void and use wait_event to wait
> > for the initialization.
>
> Hold your horses. You don't need a second queue, you just need to
> change wake_up_interruptible to wake_up.
>
> Hmm, in fact shouldn't this be wake_up_all? Otherwise what are the
> other getrandom(2) callers going to do? Ted?
Yes, this should definitely be wake_up_all()
- Ted
next prev parent reply other threads:[~2015-05-21 19:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 20:02 [PATCH v9 0/5] Seeding DRBG with more entropy Stephan Mueller
2015-05-20 20:02 ` [PATCH v9 1/5] random: Blocking API for accessing nonblocking_pool Stephan Mueller
2015-05-20 20:03 ` [PATCH v9 2/5] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-20 20:03 ` [PATCH v9 3/5] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-20 21:44 ` Herbert Xu
2015-05-21 6:10 ` Stephan Mueller
2015-05-21 6:36 ` Herbert Xu
2015-05-21 6:53 ` Stephan Mueller
2015-05-21 6:56 ` Herbert Xu
2015-05-21 7:55 ` Stephan Mueller
2015-05-21 8:19 ` random: Wake up all getrandom(2) callers when pool is ready Herbert Xu
2015-05-21 8:36 ` Stephan Mueller
2015-05-21 19:17 ` Theodore Ts'o [this message]
2015-05-22 0:23 ` Herbert Xu
2015-05-20 20:04 ` [PATCH v9 4/5] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-20 20:04 ` [PATCH v9 5/5] crypto: add jitterentropy RNG Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521191739.GP2871@thunk.org \
--to=tytso@mit.edu \
--cc=andreas.steffen@strongswan.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sandyinchina@gmail.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox