Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: pebolle@tiscali.nl, andreas.steffen@strongswan.org,
	tytso@mit.edu, sandyinchina@gmail.com,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 3/5] crypto: drbg - add async seeding operation
Date: Thu, 21 May 2015 08:10:13 +0200	[thread overview]
Message-ID: <23102012.0an2QbkQix@tachyon.chronox.de> (raw)
In-Reply-To: <20150520214408.GA17264@gondor.apana.org.au>

Am Donnerstag, 21. Mai 2015, 05:44:08 schrieb Herbert Xu:

Hi Herbert,

> On Wed, May 20, 2015 at 10:03:45PM +0200, Stephan Mueller wrote:
> >> @@ -1487,6 +1514,7 @@ unlock:
> >   */
> >  
> >  static int drbg_uninstantiate(struct drbg_state *drbg)
> >  {
> > 
> > +	cancel_work_sync(&drbg->seed_work);
> 
> This will just block until the work is done, i.e., until the
> pool is ready.  It's no different to an uninterruptible sleep.
> 
> So either just do an uninterruptible sleep, or allow the async
> seed to fail.
> 
The cancel operation is needed as otherwise my drbg context handle will be 
removed by the crypto API during the sleep. That is the whole reason why 
wait_event_interruptible is used.

So, even when using an uninterruptible sleep, the crypto API has no knowledge 
about it and I have to serialize the destruction code path with the async 
callback.

-- 
Ciao
Stephan

  reply	other threads:[~2015-05-21  6:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 20:02 [PATCH v9 0/5] Seeding DRBG with more entropy Stephan Mueller
2015-05-20 20:02 ` [PATCH v9 1/5] random: Blocking API for accessing nonblocking_pool Stephan Mueller
2015-05-20 20:03 ` [PATCH v9 2/5] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-20 20:03 ` [PATCH v9 3/5] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-20 21:44   ` Herbert Xu
2015-05-21  6:10     ` Stephan Mueller [this message]
2015-05-21  6:36       ` Herbert Xu
2015-05-21  6:53         ` Stephan Mueller
2015-05-21  6:56           ` Herbert Xu
2015-05-21  7:55     ` Stephan Mueller
2015-05-21  8:19       ` random: Wake up all getrandom(2) callers when pool is ready Herbert Xu
2015-05-21  8:36         ` Stephan Mueller
2015-05-21 19:17         ` Theodore Ts'o
2015-05-22  0:23           ` Herbert Xu
2015-05-20 20:04 ` [PATCH v9 4/5] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-20 20:04 ` [PATCH v9 5/5] crypto: add jitterentropy RNG Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23102012.0an2QbkQix@tachyon.chronox.de \
    --to=smueller@chronox.de \
    --cc=andreas.steffen@strongswan.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=sandyinchina@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox