Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

[Herbert Xu <herbert@gondor.apana.org.au>]

On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote:
> Hi, 
> 
> This patch allows nx842 coprocessor to add CRC for compression and
> check the computed CRC value for uncompression. Please let me know 
> if you have any comments.
> 
> Thanks
> Haren
> 
> commit d0b34d2e3ed41e7ec2afdbd654f0dd7716e4d4c0
> Author: Haren Myneni <haren@us.ibm.com>
> Date:   Sat Sep 12 01:20:51 2015 -0700
> 
>     crypto/nx842: Add CRC and validation support
>     
>     This patch adds CRC generation and validation support for nx-842. 
>     Add CRC flag so that nx842 coprocessor includes CRC during 
>     compression and validates during uncompression. 
>     
>     Signed-off-by: Haren Myneni <haren@us.ibm.com>

In future please post the patch without all the metadata.  You
can use the helper git format-patch to help you prepare the patch
for submission.

As to the CRC itself what is the purpose of this and wouldn't it
fail our test vectors if we had any? Remember that we also have a
software implementation now and the hardware should produce exactly
the same output as the software version.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt