Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Haren Myneni <haren@linux.vnet.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Haren Myneni <hbabu@us.ibm.com>
Subject: Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842
Date: Tue, 22 Sep 2015 22:42:19 +0800	[thread overview]
Message-ID: <20150922144219.GA12943@gondor.apana.org.au> (raw)
In-Reply-To: <CALZtONBYYTnRE6FyQKVL8kyAAb8BuXJzyGA5mYNHiXtSNcDv9Q@mail.gmail.com>

On Tue, Sep 22, 2015 at 10:39:53AM -0400, Dan Streetman wrote:
>
> hmm, that's true, and that would simplify the code a lot!  No need for
> the header anymore.  But, since the sw driver is sooo much slower, it
> would be important to be able to communicate the alignment and size
> limits to the caller of the crypto compression api, via cra_alignmask
> and cra_blocksize (for minimum size), as well as new fields for max
> size (maybe cra_maxsize) and buffer length multiple - i.e. the buffer
> length must be a multiple of N (maybe cra_blockmult or cra_blockmodulo
> or something).  Otherwise callers would get unexpectedly slow
> performance if they use the wrong alignment or size.

Right.  So who actually uses this?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2015-09-22 14:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20  0:02 [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842 Haren Myneni
2015-09-21 14:26 ` Herbert Xu
2015-09-21 15:21   ` Dan Streetman
2015-09-22 12:21     ` Herbert Xu
2015-09-22 14:39       ` Dan Streetman
2015-09-22 14:42         ` Herbert Xu [this message]
2015-09-22 15:08           ` Dan Streetman
2015-09-23  9:54             ` Herbert Xu
2015-09-24 12:32               ` Dan Streetman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150922144219.GA12943@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=ddstreet@ieee.org \
    --cc=haren@linux.vnet.ibm.com \
    --cc=hbabu@us.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox