From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tudor Ambarus <tudor-dan.ambarus@nxp.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser
Date: Tue, 3 May 2016 15:39:57 +0800 [thread overview]
Message-ID: <20160503073957.GA16836@gondor.apana.org.au> (raw)
In-Reply-To: <1461934306-29190-1-git-send-email-tudor-dan.ambarus@nxp.com>
On Fri, Apr 29, 2016 at 03:51:46PM +0300, Tudor Ambarus wrote:
>
> struct rsa_key {
> + u8 *n;
> + u8 *e;
> + u8 *d;
> + dma_addr_t dma_n;
> + dma_addr_t dma_e;
> + dma_addr_t dma_d;
> + size_t n_sz;
> + size_t e_sz;
> + bool coherent;
> + gfp_t flags;
Please don't put the DMA primitives in the generic helper. They
should stay in the driver for now.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-05-03 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 12:51 [PATCH] crypto: rsa - return raw integer for the ASN.1 parser Tudor Ambarus
2016-05-03 7:39 ` Herbert Xu [this message]
2016-05-11 7:41 ` Tudor-Dan Ambarus
2016-05-11 10:52 ` Herbert Xu
2016-05-05 10:25 ` Tudor-Dan Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503073957.GA16836@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=tudor-dan.ambarus@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox