From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tudor-Dan Ambarus <tudor-dan.ambarus@nxp.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: rsa - return raw integer for the ASN.1 parser
Date: Wed, 11 May 2016 18:52:34 +0800 [thread overview]
Message-ID: <20160511105234.GA25016@gondor.apana.org.au> (raw)
In-Reply-To: <VI1PR04MB1311A94658FE756E27429557B8720@VI1PR04MB1311.eurprd04.prod.outlook.com>
On Wed, May 11, 2016 at 07:41:31AM +0000, Tudor-Dan Ambarus wrote:
>
> If I move the DMA primitives to the driver context,
> I can't assure software coherency enforcement in rsa helper.
>
> If so, after the ANS.1 parsing, if a driver needs to enforce software
> coherency, it will have to allocate coherent memory and copy
> the ANS.1 parsed data there. Is this acceptable?
Of course you can assume the memory comes from kmalloc. Since
your driver is going to be calling the RSA helper to parse the
keys we can surely make the guarantee that the RSA helper only
returns kmalloced memory.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-05-11 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 12:51 [PATCH] crypto: rsa - return raw integer for the ASN.1 parser Tudor Ambarus
2016-05-03 7:39 ` Herbert Xu
2016-05-11 7:41 ` Tudor-Dan Ambarus
2016-05-11 10:52 ` Herbert Xu [this message]
2016-05-05 10:25 ` Tudor-Dan Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511105234.GA25016@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=tudor-dan.ambarus@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox