From: Herbert Xu <herbert@gondor.apana.org.au>
To: Salvatore Benedetto <salvatore.benedetto@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5 3/3] crypto: kpp - Add ECDH software support
Date: Tue, 31 May 2016 14:55:25 +0800 [thread overview]
Message-ID: <20160531065525.GC13948@gondor.apana.org.au> (raw)
In-Reply-To: <1462830041-7582-4-git-send-email-salvatore.benedetto@intel.com>
On Mon, May 09, 2016 at 10:40:41PM +0100, Salvatore Benedetto wrote:
>
> + do {
> + if (tries++ >= MAX_TRIES)
> + goto err_retries;
> +
> + ecc_point_mult(pk, &curve->g, priv, NULL, curve->p, ndigits);
> +
> + } while (ecc_point_is_zero(pk));
You might want to read this again. The original code did this
because it changed the private key in the loop, in your code
priv is constant...
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-05-31 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 21:40 [PATCH v5 0/3] Key-agreement Protocol Primitives (KPP) API Salvatore Benedetto
2016-05-09 21:40 ` [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP) Salvatore Benedetto
2016-05-31 6:42 ` Herbert Xu
2016-06-02 12:06 ` Benedetto, Salvatore
2016-06-08 2:54 ` Herbert Xu
2016-06-08 11:45 ` Salvatore Benedetto
2016-06-13 8:59 ` Herbert Xu
2016-05-09 21:40 ` [PATCH v5 2/3] crypto: kpp - Add DH software implementation Salvatore Benedetto
2016-05-31 6:52 ` Herbert Xu
2016-05-31 8:56 ` Benedetto, Salvatore
2016-05-09 21:40 ` [PATCH v5 3/3] crypto: kpp - Add ECDH software support Salvatore Benedetto
2016-05-31 6:55 ` Herbert Xu [this message]
2016-05-31 8:41 ` Benedetto, Salvatore
2016-05-10 7:02 ` [PATCH v5 0/3] Key-agreement Protocol Primitives (KPP) API Stephan Mueller
2016-05-10 12:49 ` Benedetto, Salvatore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531065525.GC13948@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=salvatore.benedetto@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox