Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Salvatore Benedetto <salvatore.benedetto@intel.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5 0/3] Key-agreement Protocol Primitives (KPP) API
Date: Tue, 10 May 2016 09:02:31 +0200	[thread overview]
Message-ID: <6917609.BxtCJBuMZE@positron.chronox.de> (raw)
In-Reply-To: <1462830041-7582-1-git-send-email-salvatore.benedetto@intel.com>

Am Montag, 9. Mai 2016, 22:40:38 schrieb Salvatore Benedetto:

Hi Salvatore,

> Hi Herb,
> 
> the following patchset introduces a new API for abstracting key-agreement
> protocols such as DH and ECDH. It provides the primitives required for
> implementing the protocol, thus the name KPP (Key-agreement Protocol
> Primitives).
> 
> Regards,
> Salvatore
> 
> Changes from v4:
> * If fips_enabled is set allow only P256 (or higher) as Stephan suggested

Thank you.

What I am wondering though is whether the kernel crashes in FIPS mode with 
this implementation as follows: there are test vectors for P192 which seem(?) 
to be called unconditionally. In FIPS mode, we do not have P192 and the ECC 
code returns an error when using this curve. Thus, wouldn't the self test fail 
for P192?

Now, in FIPS mode, panic() is called when a self test fails.


Ciao
Stephan

  parent reply	other threads:[~2016-05-10  7:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 21:40 [PATCH v5 0/3] Key-agreement Protocol Primitives (KPP) API Salvatore Benedetto
2016-05-09 21:40 ` [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP) Salvatore Benedetto
2016-05-31  6:42   ` Herbert Xu
2016-06-02 12:06     ` Benedetto, Salvatore
2016-06-08  2:54       ` Herbert Xu
2016-06-08 11:45         ` Salvatore Benedetto
2016-06-13  8:59           ` Herbert Xu
2016-05-09 21:40 ` [PATCH v5 2/3] crypto: kpp - Add DH software implementation Salvatore Benedetto
2016-05-31  6:52   ` Herbert Xu
2016-05-31  8:56     ` Benedetto, Salvatore
2016-05-09 21:40 ` [PATCH v5 3/3] crypto: kpp - Add ECDH software support Salvatore Benedetto
2016-05-31  6:55   ` Herbert Xu
2016-05-31  8:41     ` Benedetto, Salvatore
2016-05-10  7:02 ` Stephan Mueller [this message]
2016-05-10 12:49   ` [PATCH v5 0/3] Key-agreement Protocol Primitives (KPP) API Benedetto, Salvatore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6917609.BxtCJBuMZE@positron.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=salvatore.benedetto@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox