* [PATCH -next] crypto: caam - fix error return code in caam_qi_init()
@ 2017-04-11 16:04 Wei Yongjun
2017-04-12 8:18 ` Horia Geantă
2017-04-21 13:14 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-04-11 16:04 UTC (permalink / raw)
To: horia.geanta, dan.douglass, herbert, davem; +Cc: Wei Yongjun, linux-crypto
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return error code -ENOMEM from the kmem_cache_create() error
handling case instead of 0(err is 0 here), as done elsewhere in this
function.
Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/crypto/caam/qi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/qi.c b/drivers/crypto/caam/qi.c
index 45de8fd..1990ed4 100644
--- a/drivers/crypto/caam/qi.c
+++ b/drivers/crypto/caam/qi.c
@@ -789,7 +789,7 @@ int caam_qi_init(struct platform_device *caam_pdev)
dev_err(qidev, "Can't allocate CAAM cache\n");
free_rsp_fqs();
platform_device_unregister(qi_pdev);
- return err;
+ return -ENOMEM;
}
/* Done with the CGRs; restore the cpus allowed mask */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] crypto: caam - fix error return code in caam_qi_init()
2017-04-11 16:04 [PATCH -next] crypto: caam - fix error return code in caam_qi_init() Wei Yongjun
@ 2017-04-12 8:18 ` Horia Geantă
2017-04-21 13:14 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Horia Geantă @ 2017-04-12 8:18 UTC (permalink / raw)
To: Wei Yongjun, Dan Douglass, herbert@gondor.apana.org.au,
davem@davemloft.net
Cc: Wei Yongjun, linux-crypto@vger.kernel.org
On 4/11/2017 7:04 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENOMEM from the kmem_cache_create() error
> handling case instead of 0(err is 0 here), as done elsewhere in this
> function.
>
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Horia Geantă <horia.geanta@nxp.com>
Thanks,
Horia
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] crypto: caam - fix error return code in caam_qi_init()
2017-04-11 16:04 [PATCH -next] crypto: caam - fix error return code in caam_qi_init() Wei Yongjun
2017-04-12 8:18 ` Horia Geantă
@ 2017-04-21 13:14 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2017-04-21 13:14 UTC (permalink / raw)
To: Wei Yongjun; +Cc: horia.geanta, dan.douglass, davem, Wei Yongjun, linux-crypto
On Tue, Apr 11, 2017 at 04:04:09PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENOMEM from the kmem_cache_create() error
> handling case instead of 0(err is 0 here), as done elsewhere in this
> function.
>
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-21 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 16:04 [PATCH -next] crypto: caam - fix error return code in caam_qi_init() Wei Yongjun
2017-04-12 8:18 ` Horia Geantă
2017-04-21 13:14 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox