* [PATCH] crypto: glue_helper - Delete some dead code
@ 2017-05-10 5:52 Dan Carpenter
2017-06-19 6:40 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-05-10 5:52 UTC (permalink / raw)
To: Herbert Xu, Jussi Kivilinna
Cc: David S. Miller, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
x86, linux-crypto, kernel-janitors
We checked (nbytes < bsize) inside the loops so it's not possible to hit
the "goto done;" here. This code is cut and paste from other slightly
different loops where we don't have the check inside the loop.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c
index 24ac9fad832d..d61e57960fe0 100644
--- a/arch/x86/crypto/glue_helper.c
+++ b/arch/x86/crypto/glue_helper.c
@@ -176,9 +176,6 @@ __glue_cbc_decrypt_128bit(const struct common_glue_ctx *gctx,
src -= 1;
dst -= 1;
} while (nbytes >= func_bytes);
-
- if (nbytes < bsize)
- goto done;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: glue_helper - Delete some dead code
2017-05-10 5:52 [PATCH] crypto: glue_helper - Delete some dead code Dan Carpenter
@ 2017-06-19 6:40 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-06-19 6:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jussi Kivilinna, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, linux-crypto, kernel-janitors
On Wed, May 10, 2017 at 08:52:26AM +0300, Dan Carpenter wrote:
> We checked (nbytes < bsize) inside the loops so it's not possible to hit
> the "goto done;" here. This code is cut and paste from other slightly
> different loops where we don't have the check inside the loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-19 6:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-10 5:52 [PATCH] crypto: glue_helper - Delete some dead code Dan Carpenter
2017-06-19 6:40 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox