* [bug report] crypto: stm32 - Support for STM32 HASH module
@ 2017-08-09 21:27 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-08-09 21:27 UTC (permalink / raw)
To: lionel.debieve; +Cc: linux-crypto
Hello lionel.debieve@st.com,
The patch 8a1012d3f2ab: "crypto: stm32 - Support for STM32 HASH
module" from Jul 13, 2017, leads to the following static checker
warning:
drivers/crypto/stm32/stm32-hash.c:1088 stm32_hash_irq_thread()
error: uninitialized symbol 'err'.
drivers/crypto/stm32/stm32-hash.c
1067 static irqreturn_t stm32_hash_irq_thread(int irq, void *dev_id)
1068 {
1069 struct stm32_hash_dev *hdev = dev_id;
1070 int err;
^^^^^^^^
1071
1072 if (HASH_FLAGS_CPU & hdev->flags) {
1073 if (HASH_FLAGS_OUTPUT_READY & hdev->flags) {
1074 hdev->flags &= ~HASH_FLAGS_OUTPUT_READY;
1075 goto finish;
1076 }
1077 } else if (HASH_FLAGS_DMA_READY & hdev->flags) {
1078 if (HASH_FLAGS_DMA_ACTIVE & hdev->flags) {
1079 hdev->flags &= ~HASH_FLAGS_DMA_ACTIVE;
1080 goto finish;
1081 }
1082 }
1083
1084 return IRQ_HANDLED;
1085
1086 finish:
1087 /*Finish current request */
1088 stm32_hash_finish_req(hdev->req, err);
^^^
Never initialized.
1089
1090 return IRQ_HANDLED;
1091 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-09 21:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 21:27 [bug report] crypto: stm32 - Support for STM32 HASH module Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox