* [PATCH] hw_random: Include device.h instead of declaring struct device @ 2017-10-26 13:42 PrasannaKumar Muralidharan 2017-10-30 6:52 ` Herbert Xu 0 siblings, 1 reply; 3+ messages in thread From: PrasannaKumar Muralidharan @ 2017-10-26 13:42 UTC (permalink / raw) To: herbert, linux-crypto, linux-kernel; +Cc: PrasannaKumar Muralidharan Include linux/device.h instead of declaring struct device. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> --- include/linux/hw_random.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/hw_random.h b/include/linux/hw_random.h index bee0827..2ec9af7 100644 --- a/include/linux/hw_random.h +++ b/include/linux/hw_random.h @@ -13,6 +13,7 @@ #define LINUX_HWRANDOM_H_ #include <linux/completion.h> +#include <linux/device.h> #include <linux/types.h> #include <linux/list.h> #include <linux/kref.h> @@ -51,8 +52,6 @@ struct hwrng { struct completion cleanup_done; }; -struct device; - /** Register a new Hardware Random Number Generator driver. */ extern int hwrng_register(struct hwrng *rng); extern int devm_hwrng_register(struct device *dev, struct hwrng *rng); -- 2.10.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw_random: Include device.h instead of declaring struct device 2017-10-26 13:42 [PATCH] hw_random: Include device.h instead of declaring struct device PrasannaKumar Muralidharan @ 2017-10-30 6:52 ` Herbert Xu 2017-10-30 13:00 ` PrasannaKumar Muralidharan 0 siblings, 1 reply; 3+ messages in thread From: Herbert Xu @ 2017-10-30 6:52 UTC (permalink / raw) To: PrasannaKumar Muralidharan; +Cc: linux-crypto, linux-kernel On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: > Include linux/device.h instead of declaring struct device. > > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> Nack. We should not include a header file when a simple forward declaration is enough. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw_random: Include device.h instead of declaring struct device 2017-10-30 6:52 ` Herbert Xu @ 2017-10-30 13:00 ` PrasannaKumar Muralidharan 0 siblings, 0 replies; 3+ messages in thread From: PrasannaKumar Muralidharan @ 2017-10-30 13:00 UTC (permalink / raw) To: Herbert Xu; +Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE, open list Hi Herbert, On 30 October 2017 at 12:22, Herbert Xu <herbert@gondor.apana.org.au> wrote: > On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: >> Include linux/device.h instead of declaring struct device. >> >> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> > > Nack. We should not include a header file when a simple forward > declaration is enough. No issues. Regards, PrasannaKumar ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-30 13:00 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-26 13:42 [PATCH] hw_random: Include device.h instead of declaring struct device PrasannaKumar Muralidharan 2017-10-30 6:52 ` Herbert Xu 2017-10-30 13:00 ` PrasannaKumar Muralidharan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox