From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Kamil Konieczny <k.konieczny@partner.samsung.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
thomas.petazzoni@free-electrons.com,
gregory.clement@free-electrons.com,
miquel.raynal@free-electrons.com, oferh@marvell.com,
igall@marvell.com, nadavh@marvell.com,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 3/4] crypto: inside-secure - only update the result buffer when provided
Date: Thu, 30 Nov 2017 13:41:06 +0100 [thread overview]
Message-ID: <20171130124106.GJ30391@kwain> (raw)
In-Reply-To: <6a920087-6cf2-6074-1f95-63ce56f0abee@partner.samsung.com>
On Thu, Nov 30, 2017 at 12:52:42PM +0100, Kamil Konieczny wrote:
> On 30.11.2017 10:29, Antoine Tenart wrote:
> > On Thu, Nov 30, 2017 at 10:19:26AM +0100, Kamil Konieczny wrote:
> >> can the driver get request for final/finup/digest with null req->result ?
> >
> > I don't think that can happen. But having an update called without
> > req->result provided is a valid call (though it's not well documented).
>
> so maybe:
>
> if (sreq->finish) {
> result_sz = crypto_ahash_digestsize(ahash);
> memcpy(sreq->state, areq->result, result_sz);
> }
No, if we do this we'll lose the ability to export the current state.
Thanks,
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-30 12:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 15:42 [PATCH v2 0/4] crypto: inside-secure - set of fixes Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 1/4] crypto: inside-secure - per request invalidation Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 2/4] crypto: inside-secure - free requests even if their handling failed Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 3/4] crypto: inside-secure - only update the result buffer when provided Antoine Tenart
2017-11-30 9:19 ` Kamil Konieczny
2017-11-30 9:29 ` Antoine Tenart
2017-11-30 11:52 ` Kamil Konieczny
2017-11-30 12:41 ` Antoine Tenart [this message]
2017-11-30 14:10 ` Kamil Konieczny
2017-11-30 14:30 ` Antoine Tenart
2017-12-01 0:31 ` Herbert Xu
2017-12-01 8:11 ` Antoine Tenart
2017-12-01 10:18 ` Kamil Konieczny
2017-12-01 10:24 ` Antoine Tenart
2017-12-01 10:43 ` Kamil Konieczny
2017-12-01 10:55 ` Antoine Tenart
2017-12-01 10:36 ` Herbert Xu
2017-12-01 11:24 ` Kamil Konieczny
2017-12-01 10:35 ` Herbert Xu
2017-12-01 10:52 ` Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 4/4] crypto: inside-secure - fix request allocations in invalidation path Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130124106.GJ30391@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=igall@marvell.com \
--cc=k.konieczny@partner.samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=nadavh@marvell.com \
--cc=oferh@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox